Fix superfluous register/unregister receiver for installing new release #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 4, 2022 11:33
AnastasiaKubova
force-pushed
the
fix/register-receiver
branch
from
6147338 to
5daaddc
Compare
DmitriyKirakosyan
previously approved these changes
Mar 5, 2022
# Conflicts: # CHANGELOG.md
gediseer
reviewed
Mar 7, 2022
| @Override | ||
| public void onActivityStarted(Activity activity) { | ||
| super.onActivityStarted(activity); | ||
| registerReceiver(activity); |
There was a problem hiding this comment.
Now that we register receiver in "onStart" callback, Do we need unregister it in "onStop" so that it comes in pairs?
There was a problem hiding this comment.
No, it doesn’t depend on lifecycle of application. Receiver is registered only when distribute is enabled and is unregistered when distribute is disabled. This call need in this method to avoid issue when distribute was enabled, but activity has not started yet. If receiver was already registered so this call will be ignored.
DmitriyKirakosyan
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at our guidelines for contributions and consider the following before you submit the PR:
CHANGELOG.mdbeen updated?Related PRs or issues
AB#91443
#1603