Fix long text is not synthesized when using Cognitive Services #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
approved these changes
May 31, 2019
This was referenced Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1829.
Changelog Entry
react-say@1.2.0, by @compulim in PR #2035Description
Fixed by removing workaround for outdated Chrome quirk [compulim/react-say#7]. Details about the quirk can be found in the description of the PR. In short, to workaround Chrome quirk, we kill-and-retry speech synthesis if no
startevent is received within a second. And this interfere with Cognitive Services if the synthesized text took > 1 second to download and play.This version bump will bring these changes from
react-say:npm auditin [PR Bump dependencies compulim/react-say#9]Specific Changes
component: Bump toreact-say@1.2.0playground: Removedreact-saybecause it is not neededWe don't have automated test infrastructure for Cognitive Services today.