Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Spelling typo in resource file #397

Open
jholovacs opened this issue Mar 22, 2016 · 7 comments
Open

Spelling typo in resource file #397

jholovacs opened this issue Mar 22, 2016 · 7 comments

Comments

@jholovacs
Copy link

patch is as follows:

commit 8208989027b178c5d1e2959bc57076f2b17cf8fc
Author: Jeremy Holovacs <jeremy_holovacs@onlifehealth.com>
Date:   Tue Mar 22 13:31:32 2016 -0500

    Spelling mistake in resource file.

diff --git a/Microsoft.Research/ManagedContractsVSPropertyPane/PropertyPane.resx b/Microsoft.Research/ManagedContractsVSPropertyPane/PropertyPane.resx
index e5baaaa..0fa2952 100644
--- a/Microsoft.Research/ManagedContractsVSPropertyPane/PropertyPane.resx
+++ b/Microsoft.Research/ManagedContractsVSPropertyPane/PropertyPane.resx
@@ -943,7 +943,7 @@
     <value>91</value>
   </data>
   <data name="linkUnderstandingTheStaticChecker.Text" xml:space="preserve">
-    <value>Undestanding the static checker</value>
+    <value>Understanding the static checker</value>
   </data>
   <data name="&gt;&gt;linkUnderstandingTheStaticChecker.Name" xml:space="preserve">
     <value>linkUnderstandingTheStaticChecker</value>

@SergeyTeplyakov
Copy link
Contributor

Thanks a lot for the bug report. Don't you mind to create a PR?

@jholovacs
Copy link
Author

I didn't seem to have access to do a pr. Do I have to merge into one of
the existing branches?

On Tue, Mar 22, 2016 at 2:54 PM Sergey Teplyakov notifications@github.com
wrote:

Thanks a lot for the bug report. Don't you mind to create a PR?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#397 (comment)

@SergeyTeplyakov
Copy link
Contributor

Hm... I think there is no such thing as permissions for PR. To make a pr you need to clone the repo to your repo, make a change there and then make a PR.

@jholovacs
Copy link
Author

Well, I did clone the repo, branched locally, made a change, committed
locally, tried to push my branch to the repo and make the PR off of that,
but I couldn't. Should I have done something different?

On Tue, Mar 22, 2016 at 3:17 PM Sergey Teplyakov notifications@github.com
wrote:

Hm... I think there is no such thing as permissions for PR. To make a pr
you need to clone the repo to your repo, make a change there and then make
a PR.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#397 (comment)

@SergeyTeplyakov
Copy link
Contributor

First step - you need to fork using github (this button called Fork at the upper right corner of this page).

The reason why is following: you don't have permissions to push to this repo. Otherwise everyone who is working on large project would see all the branches that hundreds of people are using.

So just a fork using github first and then do exactly what you did.

@davidhesselbom
Copy link
Contributor

This can be closed, right?

@jholovacs
Copy link
Author

yup.
On May 16, 2016 3:59 AM, "David Hesselbom" notifications@github.com wrote:

This can be closed, right?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#397 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants