Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Slash in sourcemap path on Ubuntu 16.04 (with jake) #11111

Closed
aozgaa opened this issue Sep 23, 2016 · 3 comments
Closed

Extra Slash in sourcemap path on Ubuntu 16.04 (with jake) #11111

aozgaa opened this issue Sep 23, 2016 · 3 comments
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@aozgaa
Copy link
Contributor

aozgaa commented Sep 23, 2016

TypeScript Version: master -- commit 95c3ecc

Operating System: Ubuntu Linux 16.04

There is an extra slash at the beginning of the path to the source files referenced in the built *.js.map files. After removing the extra slash (using find-replace across all said files), source maps appear to work.

To reproduce, build with jake local.

Expected behavior:

In built/local/tsserver.js, we expect

file:///home/path/to/TypeScript/src/compiler/types.ts

(source-maps work with this change)

Actual behavior:
In built/local/tsserver.js, we get

file:////home/path/to/TypeScript/src/compiler/types.ts
@aozgaa aozgaa added Bug A bug in TypeScript Infrastructure Issue relates to TypeScript team infrastructure labels Sep 23, 2016
@mhegazy mhegazy removed the Bug A bug in TypeScript label Sep 29, 2016
@pflannery
Copy link

@mhegazy
Is it possible to bundle the source maps with each npm release in the future?, and
Is there a place I can get the current v2.3.3 maps without having to build them myself?

@mhegazy
Copy link
Contributor

mhegazy commented Dec 2, 2017

Is it possible to bundle the source maps with each npm release in the future?

We only build them for debugging, for release we do not include the maps.

Is there a place I can get the current v2.3.3 maps without having to build them myself?

nope.

@weswigham
Copy link
Member

Our sourcemaps all use relative paths now, so this is no longer a concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants