space-before-function-paren

[waderyan]

From @aochsner on November 11, 2016 22:19

We use space-before-function-paren in our eslint rules for readability. I'd like an option to format to this behavior

• VSCode Version: 1.7.1
• OS Version: macOS Sierra 10.12.1

Steps to Reproduce:

1. Type function foo () { }
2. Format the code (if it doesn't auto-format)
3. Code is formatted to function foo() { } with no mechanism to override

Copied from original issue: microsoft/vscode#15386

[waderyan]

@aochsner thank you for opening this issue. The functionality for formatting is provided by TS Server. I will migrate this feature request to their repo.

[hxshandle]

Hi team, I met the same problem, this made me so sad, I have to format my code in command line tools since the build-in formatter will change function () -> function() .

[aochsner]

So I have gotten around this issue a little bit by turning on:
"eslint.autoFixOnSave": true

in my settings.

[hxshandle]

@aochsner yeah, you approach works fine for me, thanks.

[mhegazy]

PRs welcomed.

[aochsner]

Happy to take a stab... can you point me in the right direction?

[DanielRosenwasser]

The formatting logic resides in src/services/formatting. You'll want to check out the tests/cases/fourslash directory and peek around to get a sense of how to write a formatter test.

Also see our CONTRIBUTING.md.

[aochsner]

Okay. I added a couple more test cases for InsertSpaceBeforeFunctionParenthesis. Found InsertSpaceAfterFunctionKeywordForAnonymousFuctions to cover that case. Added InsertSpaceAfterConstructor to handle that case. That should cover the main cases that http://eslint.org/docs/rules/space-before-function-paren enforces.

Let me know what else should be done. Thanks!

[mhegazy]

thanks @aochsner!