static class properties invalid

[egamma]

From @nwehrle on February 9, 2016 21:17

I use eslint to lint my jsx files. Before I switched to salsa, the linting inside the editor worked fine. After switching to salsa the linting fails inside the editor.

Salsa is enabled:

Linting from the shell still works without any errors or warnings.
I expect vscode to not show any linting errors.

System:
OSX 10.11.2
vscode 0.10.8
db71ac615ddf9f33b133ff2536f5d33a77d4774e

jsconfig.json:

{
  "compilerOptions": {
    "target": "ES6",
    "module": "system",
    "experimentalDecorators": true
  },

  "exclude": [
    "node_modules"
  ]
}

User settings:

{
  "javascript.validate.enable": false,
  "editor.tabSize": 2,
  "files.trimTrailingWhitespace": true,
  // Migrated from previous "File | Auto Save" setting:
  "files.autoSave": "onFocusChange"
}

Partial eslintrc:

 "rules": {
    "func-names": 0,
    "no-unused-expressions": 0,
    "id-length": 0,
    "no-multi-spaces": 0,
    "no-mixed-spaces-and-tabs": 2,

    "no-unused-vars": [1, {"vars": "all", "args": "none"}],
    "react/jsx-uses-react": 1,
    "react/prop-types": 0,
    "no-console": 0
  },
  "plugins": [
    "react"
  ]

Copied from original issue: microsoft/vscode#2866

[egamma]

From @nwehrle on February 10, 2016 9:55

The lint error message is:
'property declarations' can only be used in a .ts file.
(property) SearchProfileList.propTypes: {
list: any;
getSearchProfileList: any;
deleteSearchProfile: any;
editSearchProfile: any;
location: any;

Nette Grüsse nach Wollishofen :)

[egamma]

Nette Grüsse nach Wollishofen :)
Danke 😄

The warning comes from Salsa - moving.

[dvdzkwsk]

@same thing here, looking at the default settings in VSCode it appears:

"javascript.validate.enable"

is no longer a setting? I realize this issue has been moved to TypeScript, but it doesn't seem like you can disable validation for JS in VSCode anymore?

Also, note that the same error occurs when using Type aliases (such as with Flow):

type aliases can only be used in a .ts file

type Action = {
  type: string,
  payload: Object,
  error?: Object,
};

[egamma]

looking at the default settings in VSCode it appears:
"javascript.validate.enable"
is no longer a setting?

correct, javascript.validate.enable does not apply to Salsa anymore. The existing JS language service supported additional warnings that are currently not supported by Salsa and this is why we recommend to use a linter like eslint or jshint.

[dvdzkwsk]

Thanks for the clarification!

[RyanCavanaugh]

This code isn't valid JavaScript, nor does Babel understand this syntax. It seems like this is a correct error to issue. How is this being transpiled?

[JeandeCampredon]

This code is usable with the stage-0 preset of babel.