Unable to do module augmentation

[yortus]

TypeScript Version:

nightly (1.9.0-dev.20160217)

Code:

// OK - fixed by #6742
declare module 'express' {
    interface Request {
        id: number;
    }
}

// ERROR: Cannot augment module 'knockout' because it resolves to a non-module entity
declare module 'knockout' {
    interface KnockoutStatic {
        track(obj: any, propertyNames?: string[]): any;
        mapping: KnockoutMapping;
    }
}

// ERROR: Cannot augment module 'jquery' because it resolves to a non-module entity
declare module 'jquery' {
    interface JQuery {
        timepicker(): JQuery;
        timepicker(options: TimePickerOptions): JQuery;
    }
}

Asking the same thing as #6722, but for jquery and knockout.

[DanielRosenwasser]

I'm assuming that the relevant .d.ts files are part of your compilation, right? Do you have a minimal repro?

[yortus]

@DanielRosenwasser here's a little repro project: https://github.com/yortus/repro-7148

[Guria]

I have failed to augment moment as well

[vladima]

discussed offline with @mhegazy: this is not a bug in implementation but rather the consequence of the fact that currently typings for 'knockout' and 'jquery' are not augmentation-friendly - they both export variable with some global type as module and so i.e. in case of JQuery

declare module 'jquery' {
    interface JQuery {
        timepicker(): JQuery;
        timepicker(options: TimePickerOptions): JQuery;
    }
}

module 'jquery' is defined as

declare module "jquery" {
    export = $;
}
declare var jQuery: JQueryStatic;
declare var $: JQueryStatic;

so type of 'jquery' is effectively JQueryStatic that does not have nested interface JQuery thus the failure.

What you can do:

• UMD modules support that will be shipped TS 2.0 will support this scenario
• for now since JQueryStatic is defined in a global scope you can use global augmentation to patch it.

/// <reference path="./jquery.d.ts" />
declare global {
    interface JQuery {
        timepicker(): JQuery;
    }
}

$().timepicker();

export {}

[cervengoc]

@vladima Could you please add a few words about how the above mentioned UMD support solves this? I'm currently stuck with this situation and wouldn't like to use the global scope declarations unless I have no other way.

[mhegazy]

@vladima Could you please add a few words about how the above mentioned UMD support solves this? I'm currently stuck with this situation and wouldn't like to use the global scope declarations unless I have no other way.

http://www.typescriptlang.org/docs/handbook/declaration-files/library-structures.html#umd does not cover your question?

[cervengoc]

It doesn't get me closer, as I still don't see what the working alternative is for

declare module 'jquery' {
    interface JQuery {
        timepicker(): JQuery;
        timepicker(options: TimePickerOptions): JQuery;
    }
}

as it still doesn't work at me. The compiler still can't see these extension methods.

[mhegazy]

where is jquery defined?