Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call signature caching #10703

Merged
merged 2 commits into from
Sep 4, 2016
Merged

Fix call signature caching #10703

merged 2 commits into from
Sep 4, 2016

Conversation

ahejlsberg
Copy link
Member

@ahejlsberg ahejlsberg commented Sep 4, 2016

Fixes #10697. Previously we used anySignature both as the signature for any objects and as a marker to indicate in-process resolution. This PR introduces a separate resolvingSignature for the latter case such that a result of anySignature is properly cached.

@nisimjoseph
Copy link

thank you.
when the fix will be available in dev build ?

@vladima
Copy link
Contributor

vladima commented Sep 4, 2016

👍

can we add original repro as a test case (at least we'll be aware that something is not right if execution time of tests will significantly increase)?

@ahejlsberg
Copy link
Member Author

@vladima Sure, I'll add the original repro.

@ahejlsberg ahejlsberg merged commit 2379000 into master Sep 4, 2016
@ahejlsberg ahejlsberg deleted the fixSignatureCache branch September 4, 2016 18:54
mhegazy added a commit that referenced this pull request Sep 6, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants