Skip to content

Conversation

Stevenic
Copy link
Contributor

The new OAuthPrompt needs to receive "event" and "invoke" type activities. That means that since we can no-longer expect only "message" activities passed to dialogs we should add some additional protection in a few places.

@Stevenic Stevenic requested a review from johnataylor April 19, 2018 22:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 276

  • 7 of 9 (77.78%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 83.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs/src/prompts/prompt.ts 2 3 66.67%
libraries/botbuilder-dialogs/src/waterfall.ts 5 6 83.33%
Totals Coverage Status
Change from base Build 270: -0.08%
Covered Lines: 1556
Relevant Lines: 1816

💛 - Coveralls

Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I have these in the C# version. I made those changes on the choice branch so they can go in with that.

@Stevenic Stevenic merged commit fbf16f5 into master Apr 20, 2018
@Stevenic Stevenic deleted the stevenic/prompt-tweaks branch April 20, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants