Stevenic/dialog tweaks #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 351
💛 - Coveralls |
Fixed a bug in DialogSet.createContext()
johnataylor
approved these changes
Apr 27, 2018
| * | ||
| * ```JS | ||
| * dialogs.add('namePrompt', [ | ||
| * async function (dc) { |
There was a problem hiding this comment.
suggestion: consider making this an arrow function?
async (dc) => { }
chrimc62
pushed a commit
that referenced
this pull request
May 3, 2018
* renamed Control and CompositeControl classes * Renamed DialogContext.instance to DialogContext.currentDialog * Fixed circular dependency and updated unit tests * Updated samples to use new dialog constructs * published updated bits * Changed DialogResult to DialogCompletion * Updated samples Fixed a bug in DialogSet.createContext() * published new bits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.