Initial version of typescript support for LUISGen. #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 371
💛 - Coveralls |
Stevenic
reviewed
May 1, 2018
| /** A number together with units returned by a recognizer. */ | ||
| export interface NumberWithUnits { | ||
| /** A recognized number if any. */ | ||
| readonly number?: number; |
There was a problem hiding this comment.
number [](start = 13, length = 6)
Should this be value or something? Number isn't a reserved word but it's a type in TypeScript
Stevenic
reviewed
May 1, 2018
| @@ -0,0 +1 @@ | |||
| {"version":3,"file":"recognizerResult.js","sourceRoot":"","sources":["../src/recognizerResult.ts"],"names":[],"mappings":";AAAA;;GAEG;AACH;;;EAGE"} No newline at end of file | |||
There was a problem hiding this comment.
There's no src file... If you didn't make an changes to core-extensions could you revert all of these lib files?
There was a problem hiding this comment.
This was in a previous checkin that added recognizerResult.ts to core-extensions. Happy to revert the other ones, but shouldn't these be added?
Stevenic
approved these changes
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.