Skip to content

rename secretKey to padlock #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2018
Merged

rename secretKey to padlock #435

merged 1 commit into from
Sep 15, 2018

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Sep 14, 2018

rename secretKey to padlock
add backcompat mapping.
update unit tests to test it

@tomlm tomlm mentioned this pull request Sep 14, 2018
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1411

  • 15 of 15 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 69.943%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build 1408: -0.02%
Covered Lines: 2235
Relevant Lines: 3052
💛 - Coveralls

@tomlm tomlm merged commit 53f2cf8 into master Sep 15, 2018
@tomlm tomlm deleted the tomlm/secretkey branch September 15, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@benbrown benbrown benbrown approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomlm @coveralls @benbrown