Skip to content

make encrypt()/decrypt() do nothing with null or empty values #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2018
Merged

make encrypt()/decrypt() do nothing with null or empty values #449

merged 1 commit into from
Sep 18, 2018

Conversation

tomlm
Copy link
Contributor

@tomlm tomlm commented Sep 18, 2018

recipes can end up with empty strings which our encrypt routines blow up on.
fix for microsoft/botbuilder-tools#510

@tomlm tomlm mentioned this pull request Sep 18, 2018
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1472

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 70.247%
Totals Coverage Status
Change from base Build 1470: 0.1%
Covered Lines: 2294
Relevant Lines: 3116
💛 - Coveralls

@tomlm tomlm merged commit 950e165 into master Sep 18, 2018
@tomlm tomlm deleted the tomlm/encryptempty branch September 18, 2018 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@vishwacsena vishwacsena vishwacsena approved these changes

@carlosscastro carlosscastro carlosscastro approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomlm @coveralls @vishwacsena @carlosscastro