New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NetCoreDbg to Debug Adapter Protocol implementors list #9

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@ayuckhulk
Contributor

ayuckhulk commented Oct 17, 2018

No description provided.

@@ -42,6 +42,7 @@ The following table lists the known debug adapters that implement the Debug Adap
[React Native Tools](https://marketplace.visualstudio.com/items?itemName=vsmobile.vscode-react-native)|[@MSLaguana](https://github.com/MSLaguana)|[Microsoft/vscode-react-native](https://github.com/Microsoft/vscode-react-native/issues)
[Ruby](https://marketplace.visualstudio.com/items?itemName=rebornix.Ruby)|[@rebornix](https://github.com/rebornix)|[rubyide/vscode-ruby](https://github.com/rubyide/vscode-ruby)
[SWF](https://marketplace.visualstudio.com/items?itemName=bowlerhatllc.vscode-nextgenas)|[@joshtynjala](https://github.com/joshtynjala)|[BowlerHatLLC/vscode-nextgenas](https://github.com/BowlerHatLLC/vscode-nextgenas)
[NetCoreDbg](https://github.com/Samsung/netcoredbg)|[@ayuckhulk](https://github.com/ayuckhulk)|[Samsung/netcoredbg](https://github.com/Samsung/netcoredbg)

This comment has been minimized.

@mickaelistria

mickaelistria Oct 17, 2018

Should this say the framework/language instead of the the name. So it shoud be

[.NET Core](https://github.com/Samsung/netcoredbg)|[@ayuckhulk](https://github.com/ayuckhulk)|[Samsung/netcoredbg](https://github.com/Samsung/netcoredbg)

This comment has been minimized.

@ayuckhulk

ayuckhulk Oct 17, 2018

Contributor

I am not sure. But in your example the .NET Core link should point to https://github.com/dotnet/coreclr instead of netcoredbg. Maybe just Debugger for .NET Core?

This comment has been minimized.

@mickaelistria

mickaelistria Oct 17, 2018

Yes "Debugger for .NET Core" seems fine as similar pattern is already used in other lines.

@ayuckhulk ayuckhulk force-pushed the ayuckhulk:add-netcoredbg branch from 3a25cb8 to 4ff512f Oct 17, 2018

@weinand weinand merged commit 4e488b2 into Microsoft:gh-pages Nov 2, 2018

1 check passed

license/cla All CLA requirements met.
@weinand

This comment has been minimized.

Member

weinand commented Nov 2, 2018

Thanks for the PR.

@weinand weinand added this to the October 2018 milestone Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment