Skip to content

Conversation

ljqx
Copy link
Contributor

@ljqx ljqx commented Apr 19, 2016

  1. fixes of string and number validator.
  2. passive and array validator and corresponding tests.

@ljqx
Copy link
Contributor Author

ljqx commented Apr 19, 2016

@lyweiwei , this change adds passive validator which is needed by ko-schema.

@coveralls
Copy link

Coverage Status

Coverage decreased (-16.2%) to 83.81% when pulling ccc9c9b on ljqx:merge-with-SD into df1a627 on Microsoft:master.

@lyweiwei
Copy link
Contributor

@ljqx could you add some test cases to silence coveralls?

@ljqx
Copy link
Contributor Author

ljqx commented Apr 19, 2016

@lyweiwei , sure.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 00d0fa2 on ljqx:merge-with-SD into df1a627 on Microsoft:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 774e488 on ljqx:merge-with-SD into df1a627 on Microsoft:master.

@ljqx
Copy link
Contributor Author

ljqx commented Apr 19, 2016

@lyweiwei , I've imported some code of component/humanize in this PR, for keeping the coverage, I commented out unused code in it.

@lyweiwei lyweiwei merged commit d9d3786 into microsoft:master Apr 19, 2016
ljqx added a commit that referenced this pull request Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants