New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata caching issue with AE on connection #361

Merged
merged 7 commits into from Jun 28, 2017

Conversation

Projects
None yet
6 participants
@AfsanehR
Member

AfsanehR commented Jun 26, 2017

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Jun 26, 2017

Codecov Report

Merging #361 into RTW_6.2.0 will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@               Coverage Diff               @@
##             RTW_6.2.0     #361      +/-   ##
===============================================
- Coverage        40.09%   40.08%   -0.02%     
- Complexity        1881     1882       +1     
===============================================
  Files              107      107              
  Lines            24484    24486       +2     
  Branches          4037     4039       +2     
===============================================
- Hits              9817     9814       -3     
+ Misses           12833    12830       -3     
- Partials          1834     1842       +8
Flag Coverage Δ Complexity Δ
#JDBC41 39.94% <80%> (-0.05%) 1874 <0> (-2)
#JDBC42 39.99% <80%> (+0.09%) 1879 <0> (+11) ⬆️
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 42.39% <80%> (+0.68%) 136 <0> (+7) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 41.57% <0%> (-3.38%) 14% <0%> (-2%)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 47.4% <0%> (-1.49%) 9% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.23% <0%> (-0.42%) 187% <0%> (-4%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.28% <0%> (-0.22%) 210% <0%> (-2%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 76.72% <0%> (-0.17%) 4% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 44.72% <0%> (-0.11%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.42% <0%> (+0.21%) 46% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.66% <0%> (+0.22%) 57% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 39.65% <0%> (+0.27%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f3e8e9...63d764f. Read the comment docs.

@v-nisidh v-nisidh requested a review from TobiasSQL Jun 26, 2017

try {
String sPrepStmt = "update ctstable2 set PRICE=PRICE*20 where TYPE_ID=?";
System.out.println("Prepared Statement String :" + sPrepStmt);

This comment has been minimized.

@v-nisidh

v-nisidh Jun 27, 2017

Contributor

Remove sysouts. better to use logger. Simple java.util.logger

testExecuteBatch1();
}
public void testAddBatch1() {

This comment has been minimized.

@v-nisidh

v-nisidh Jun 27, 2017

Contributor

Suggestion: Adding javadocs will give hint to developers related to what we are going to test.

}
private static void dropTable() throws SQLException {
stmt.executeUpdate("if object_id('" + "ctstable2" + "','U') is not null" + " drop table " + "ctstable2");

This comment has been minimized.

@v-nisidh

v-nisidh Jun 27, 2017

Contributor

Please use Utils.dropObjectIfExists(tableName,"IsTable",stmt) function to drop table.

*
*/
@RunWith(JUnitPlatform.class)
public class BatchExecution extends AbstractTest {

This comment has been minimized.

@v-nisidh

v-nisidh Jun 27, 2017

Contributor

Can we rename BatchExecutionTest ?

@AfsanehR AfsanehR merged commit f737b59 into Microsoft:RTW_6.2.0 Jun 28, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ajlam ajlam removed the PR Under Review label Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment