Metadata caching issue with AE on connection #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## RTW_6.2.0 #361 +/- ##
===============================================
- Coverage 40.09% 40.08% -0.02%
- Complexity 1881 1882 +1
===============================================
Files 107 107
Lines 24484 24486 +2
Branches 4037 4039 +2
===============================================
- Hits 9817 9814 -3
+ Misses 12833 12830 -3
- Partials 1834 1842 +8
Continue to review full report at Codecov.
|
v-nisidh
reviewed
Jun 27, 2017
| try { | ||
| String sPrepStmt = "update ctstable2 set PRICE=PRICE*20 where TYPE_ID=?"; | ||
|
|
||
| System.out.println("Prepared Statement String :" + sPrepStmt); |
There was a problem hiding this comment.
Remove sysouts. better to use logger. Simple java.util.logger
v-nisidh
reviewed
Jun 27, 2017
| testExecuteBatch1(); | ||
| } | ||
|
|
||
| public void testAddBatch1() { |
There was a problem hiding this comment.
Suggestion: Adding javadocs will give hint to developers related to what we are going to test.
v-nisidh
reviewed
Jun 27, 2017
| } | ||
|
|
||
| private static void dropTable() throws SQLException { | ||
| stmt.executeUpdate("if object_id('" + "ctstable2" + "','U') is not null" + " drop table " + "ctstable2"); |
There was a problem hiding this comment.
Please use Utils.dropObjectIfExists(tableName,"IsTable",stmt) function to drop table.
TobiasSQL
approved these changes
Jun 27, 2017
v-nisidh
reviewed
Jun 27, 2017
| * | ||
| */ | ||
| @RunWith(JUnitPlatform.class) | ||
| public class BatchExecution extends AbstractTest { |
There was a problem hiding this comment.
Can we rename BatchExecutionTest ?
v-nisidh
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.