Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export driver in automatic module #732

Merged
merged 8 commits into from
Jul 6, 2018
Merged

Export driver in automatic module #732

merged 8 commits into from
Jul 6, 2018

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Jun 29, 2018 •
edited
Loading

  • Adds automatic-module-name to Manifest
  • All JUnit Tests made public (to support module architecture)

@codecov-io
Copy link

codecov-io commented Jul 1, 2018 •
edited
Loading

Codecov Report

Merging #732 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #732      +/-   ##
============================================
+ Coverage     48.42%   48.43%   +0.01%     
+ Complexity     2747     2743       -4     
============================================
  Files           115      115              
  Lines         27156    27156              
  Branches       4547     4547              
============================================
+ Hits          13149    13152       +3     
+ Misses        11850    11839      -11     
- Partials       2157     2165       +8
Flag Coverage Δ Complexity Δ
#JDBC42 47.91% <ø> (-0.11%) 2695 <ø> (-12)
#JDBC43 48.32% <ø> (-0.03%) 2741 <ø> (-1)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-1.13%) 16% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.27% <0%> (-0.87%) 242% <0%> (-8%)
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 48.51% <0%> (-0.19%) 332% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 53.41% <0%> (+0.18%) 264% <0%> (+2%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.36% <0%> (+0.29%) 0% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.67% <0%> (+0.43%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.08% <0%> (+1.34%) 108% <0%> (+2%) ⬆️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.59% <0%> (+1.48%) 12% <0%> (+1%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerException.java 76.56% <0%> (+1.56%) 31% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 465018b...f492eaa. Read the comment docs.

@cheenamalhotra cheenamalhotra changed the title Added Module-Info support to export driver in 'mssqljdbc' module Added Module-Info support to export driver in module Jul 3, 2018
@cheenamalhotra cheenamalhotra changed the title Added Module-Info support to export driver in module Export driver in automatic module Jul 4, 2018
@cheenamalhotra cheenamalhotra added this to the 7.0.0 milestone Jul 4, 2018
lilgreenbird
lilgreenbird reviewed Jul 5, 2018
View reviewed changes
src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPTypesTest.java Outdated
}
}

/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this whole file change? is it formatting only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert the formatting - unnecessary here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow GitHub is doing unnecessary comparisons, I compared the file to dev branch's and there's no formatting change actually. The only change is in changing private Junit test functions to public.

@cheenamalhotra cheenamalhotra mentioned this pull request Jul 6, 2018
Closed
2 tasks
@cheenamalhotra cheenamalhotra merged commit 7243eb5 into microsoft:dev Jul 6, 2018
@cheenamalhotra cheenamalhotra mentioned this pull request Jul 9, 2018
Closed
cheenamalhotra added a commit that referenced this pull request Jul 31, 2018
@cheenamalhotra
Update master post RTW 7.0 release (#766)
9106feb 
* Update Snapshot for upcoming RTW release v7.0.0

* Change order of logic for checking the condition for using Bulk Copy API (#736)

Fix | Change order of logic for checking the condition for using Bulk Copy API (#736)

* Update CHANGELOG.md

* Merge pull request #732 from cheenamalhotra/module (Export driver in automatic module)

Introduce Automatic Module Name in POM.

* Update CHANGELOG.md

* Change Sha1HashKey to CityHash128Key for generating PreparedStatement handle and metadata cache keys (#717)

* Change Sha1HashKey to CityHash128Key

* Formatted code

* Prepared statement performance fixes

1) Further speedups to prepared statement hashing

2) Caching of '?' chararacter positiobs in prepared statements to speed parameter substitution

* String compare for hash keys
added missing line for bulkcopy tests.

* comment change

* Move CityHash class to a separate file

* spacings fixes
cleaner code & logic

* Add | Adding useBulkCopyForBatchInsert property to Request Boundary methods (#739)

* Apply the collation name change to UTF8SupportTest

* Package changes for CityHash with license information (#740)

* Reformatted Code + Updated formatter (#742)

* Reformatted Code + Updated formatter

* Fix policheck issue with 'Country' keyword (#745)

* Adding a new test for beginRequest()/endRequest() (#746)

* Add | Adding a new test to notify the developers to consider beginRequest()/endRequest() when adding a new Connection API

* Fix | Fixes for issues reported by static analysis tools (SonarQube + Fortify) (#747)

* handle buffer reading

for invalid buffer input by user

* Revert "handle buffer reading"

This reverts commit 11e2bf4.

* updated javadocs (#754)

* fixed some typos in javadocs (#760)

* API and JavaDoc changes for Spatial Datatypes (#752)

Add | API and JavaDoc changes for Spatial Datatypes (#752)

* Disallow non-parameterized queries for Bulk Copy API for batch insert (#756)

fix | Disallow non-parameterized queries for Bulk Copy API for batch insert (#756)

* Formatting | Change scope of unwanted Public APIs + Code Format (#757)

* Fix unwanted Public APIs.
* Updated formatter to add new line to EOF + formatted project

* Release | Release 7.0 changelog and version update (#748)

* Updated Changelog + release version changes

* Changelog entry updated as per review.

* Updated changelog for new changes

* Terminology update: request boundary declaration APIs

* Trigger Appveyor

* Update Samples and add new samples for new features (#761)

* Update Samples and add new Samples for new features

* Update samples from Peter

* Updated JavaDocs

* Switch to block comment

* Update License copyright (#767)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rene-ye rene-ye rene-ye approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@ulvii ulvii ulvii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cheenamalhotra @codecov-io @rene-ye @lilgreenbird @ulvii