Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with Geography.point method having coordinates reversed #853

Merged
merged 6 commits into from Nov 28, 2018

Conversation

6 participants
@peterbae
Copy link
Member

commented Oct 25, 2018

Fixes issue #851.

According to this page, Geography::point method has the coordinates reversed (lat, long instead of the usual long, lat) compared to the other methods of inserting a Geography point. This PR aligns the driver behavior with the expected behavior.

@codecov-io

This comment has been minimized.

Copy link

commented Oct 25, 2018

Codecov Report

Merging #853 into dev will increase coverage by 0.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #853      +/-   ##
============================================
+ Coverage     48.71%   48.72%   +0.01%     
- Complexity     2796     2815      +19     
============================================
  Files           116      118       +2     
  Lines         27877    27867      -10     
  Branches       4650     4639      -11     
============================================
  Hits          13579    13579              
- Misses        12091    12092       +1     
+ Partials       2207     2196      -11
Flag Coverage Δ Complexity Δ
#JDBC42 48.22% <55.55%> (+0.02%) 2772 <3> (+21) ⬆️
#JDBC43 48.63% <55.55%> (+0.02%) 2810 <3> (+19) ⬆️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 45.77% <50%> (-0.62%) 110 <0> (+2)
...n/java/com/microsoft/sqlserver/jdbc/Geography.java 52.38% <60%> (ø) 15 <3> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (-2.2%) 15% <0%> (ø)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 60.99% <0%> (-0.44%) 89% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56% <0%> (-0.24%) 0% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.58% <0%> (-0.15%) 264% <0%> (+1%)
...va/com/microsoft/sqlserver/jdbc/TimeoutPoller.java 83.78% <0%> (ø) 9% <0%> (?)
...a/com/microsoft/sqlserver/jdbc/TimeoutCommand.java 100% <0%> (ø) 5% <0%> (?)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.57% <0%> (+0.05%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0b18f...60bb242. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018

@peterbae peterbae dismissed stale reviews from cheenamalhotra, rene-ye, and lilgreenbird via 093783d Nov 21, 2018

@cheenamalhotra cheenamalhotra added this to In progress in MSSQL JDBC Nov 21, 2018

@ulvii

ulvii approved these changes Nov 28, 2018

@peterbae peterbae changed the title Fix Geometry.point coordinates Fix Geography.point coordinates Nov 28, 2018

@peterbae peterbae changed the title Fix Geography.point coordinates Fix Geography.point method Nov 28, 2018

@peterbae peterbae merged commit d968294 into microsoft:dev Nov 28, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

MSSQL JDBC automation moved this from In progress to Closed/Merged PRs Nov 28, 2018

@ulvii ulvii changed the title Fix Geography.point method Fixed an issue with Geography.point method having coordinates reversed Nov 29, 2018

ulvii added a commit that referenced this pull request Nov 30, 2018

Fix Geography.point method (#853)
Fix | Fixes Geography.point method to expected behavior (#853)

ulvii added a commit that referenced this pull request Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.