Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature | Introduce NTLM authentication mode #998

Merged
merged 118 commits into from Jun 10, 2019

Conversation

@lilgreenbird
Copy link
Member

commented Mar 19, 2019

Introduces support for NTLM Authentication in the driver as requested in issue #696.
This feature currently supports authentication with connection string as under:

jdbc:sqlserver://<hostname>;integratedSecurity=true;authenticationScheme=NTLM;domain=<server_domain>;user=<userName>;password=<password>

  • Supports Extended Protection enabled SQL Servers.
  • Does not support Extended Protection + Encrypted connection
    Implementation of Channel Binding is in progress.

lilgreenbird and others added some commits Dec 11, 2018

Merge pull request #3 from ulvii/ntlmv2
Add | JUnit tests
Merge remote-tracking branch 'upstream/dev' into newntlm
# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/TestUtils.java

cheenamalhotra added some commits May 30, 2019

Merge branch 'ms-dev' into newntlm
# Conflicts:
#	src/test/java/com/microsoft/sqlserver/jdbc/TestUtils.java

@lilgreenbird lilgreenbird dismissed stale reviews from cheenamalhotra, peterbae, and rene-ye via 1fa9143 Jun 10, 2019

@ulvii

ulvii approved these changes Jun 10, 2019

@lilgreenbird lilgreenbird merged commit 3447732 into microsoft:dev Jun 10, 2019

6 checks passed

Microosft.mssql-jdbc.linux #20190610.9 succeeded
Details
Microosft.mssql-jdbc.macOS #20190610.9 succeeded
Details
Microsoft.mssql-jdbc.windows #20190610.13 succeeded
Details
Static Code Analysis #20190610.8 succeeded
Details
license/cla All CLA requirements met.
Details
mssql-jdbc-coco #20190610.9 succeeded
Details

MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Jun 10, 2019

cheenamalhotra added a commit that referenced this pull request Jun 15, 2019

Merge dev to master post release v7.3.1 (#1084)
* Update SNAPSHOT for 7.3.1 driver release (#1012)

* Fix | Fix BulkCopyColumnMappingTest random failures due to unordered Selects (#999)

* Test | Improvements in LobsTest exception and failure handling (#1008)

* Fix | Fix hardcoded Trigger Name causing failures in concurrent builds (#1004)

* Test | Fix random test issues with BVT Test (#994)

* Fix | Fix usage of Deprecated API in BatchExecutionWithBulkCopyTest (#1006)

* Tests | Fix LobsStreamingTest to close all streams and resources appropriately (#1019)

* Tests | Random generate Message Id and drop later to avoid conflicts with already set messages. (#1017)

* Test | Add test to validate microsoft.sql.DateTimeOffset interchangeable behavior (#1005)

* Tests | Support multi-platform testing with exclusion tags and fix Skipping tests (#1015)

* Tests | Support multi-platform testing with exclusion tags and fix skipping test behavior

* Update Azure Pipelines script  + minor changes

* Azure DB test compatibility added + Removed old tags

* Fix AE tests

* Tag for Azure DB

* Minor fix

* Jacoco Merge capability

* Exclude tags for tests not compatible

* Reduce connections and save resources

* Fix tests

* Fix conflict issues

* Conflict changes reverted

* Fix ActivityID map getting not cleaned up properly (#1020)

Fix | Fix ActivityID map getting not cleaned up properly (#1020)

* Fix | Fixed PreparedStatement exception handling (#1003)

* Fix | Fix for ResultSets being consumed when reading warnings (#991)

* Tests | Move Exclude Groups to Constants and finalize them (#1032)

* Tests | Skip newly added tests not supported on DW (#1036)

* Docs | Update Stable Release version (#1039)

*  Maven | Update all Maven plugins and dependencies to latest versions  (#1037)

* Add formatErrorMsg for comparing error messages in tests (#1034)

added formatErrorMsg to compare messages and cleanup

* Tests | Code Coverage improvement for DataClassification class + Fix conditional tests (#1041)

* Tests | Add logging stream handler for tests (#1027)

* Feature | Introduce Java 12 Support to driver and build additional "jre12" JAR (#1050)

* Tests | Add tests for SQLServerConnection to improve code coverage (#1047)

moved and renamed from connection/ConnectDriverTest to add more tests calling package private methods

* Fix | Mark spatial datatypes as valid (#1035)

Mark spatial datatypes as valid

* Fix SQLServerDatabaseMetadata.getMaxConnections() API query (#1009)

* Fix | Fix SharedTimer implementation to use class level lock for thread safety (#1046)

* Always Encrypted Usability Modifications (#902)

* Changes to allow easier access when setting the Azure Key Vault provider's client ID and key for Always Encrypted functionality. This now allows these fields to be set via the connection string URL (not recommended) or via the driver's connection properties (recommended). This is required to use Always Encrypted functionality within data processing solutions that initiate the driver for you such as Apache Spark clusters or third-party tools where you cannot programmatically call the static 'registerColumnEncryptionKeyStoreProviders' method on the SQLServerConnection class.

* Proposed changes for property names and functionalities.

* Fix | Fix issues with Login Timeout not getting applied appropriately. (#1049)

* Add | Implement hashCode() and equals() APIs for SQLServerDataTable and SQLServerDataColumn (#1025)

* Performance | Improve performance of SQLServerDataTable.internalAddRow() function (#990)

* Update Maven plugins + configure Surefire plugin (#1068)

* Performance | Remove Enum.values() calls to avoid unnecessary array cloning  (#1065)

* Performance | Replace Enum:values() with static VALUES array

*  Test | Fix DB Metadata tests + fix maven warnings + clean all objects (#1060)

* Maven | Add Shade plugin configuration to package the driver in an uber-jar (#1043)

* Config | Add Checkstyle configuration file (#1067)

* Fix | Align DatabaseMetadata.getColumns with JDBC 4.3 Specifications (#1016)

* Fix | Align DatabaseMetadata.getColumns with JDBC 4.3 Specifications

* Fix | Default catalog behavior with getColumns()

* Add | SS_IS_SPRASE and SS_IS_COLUMN_SET columns

* Add | Catalog switching and backwards compatibility query edit

* Fix | Driver eating exception and the ability to count to 12

* Fix | SS_UDT_ASSEMBLY_TYPE_NAME length can be greater than 128

* Add | Handle preparedstatement closing

* Fix | Unhandled exception caused by merge error

* Fix | Format file

* Fix | Add workaround for Azure DW

* Fix | Flipping null comparisons according to coding standards

* Maven | Use Outputfile configuration to rename Shaded Jar name (#1078)

* Feature | Introduce NTLM authentication mode (#998)

Introduces support for NTLM Authentication in the driver

* Fix | Misleading error message in CallableStatement (#1064)

* Fix | Callablestatement not setting parameter properly when columns aren't found

* Fix | Typo in tests

* Fix | Typo fix cont...

* Add | Tests

* Fix | null check

* Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java

Co-Authored-By: Cheena Malhotra <v-chmalh@microsoft.com>

* Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java

Co-Authored-By: Cheena Malhotra <v-chmalh@microsoft.com>

* Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java

Co-Authored-By: Cheena Malhotra <v-chmalh@microsoft.com>

* Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java

Co-Authored-By: Cheena Malhotra <v-chmalh@microsoft.com>

* Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java

Co-Authored-By: Cheena Malhotra <v-chmalh@microsoft.com>

* Update src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableMixedTest.java

Co-Authored-By: Cheena Malhotra <v-chmalh@microsoft.com>

* Feature | Add new connection property 'useFmtOnly' to retrieve Parameter Metadata

Adds a new way to query metadata for instances where sp_describe_undeclared_parameters fail.

* Maven | Merge Shade plugins + update dependent library versions (#1081)

* v7.3.1 Preview Release preparations (#1083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.