add cells, rows, columns functions #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 27, 2016 20:54
|
Changes Unknown when pulling cbfd7e3 on lesliekim:master into * on Microsoft:0.1.0-dev*. |
demos/grid-view/index.js
Outdated
| cells, | ||
| } from '../../js/vnext/projection'; | ||
| import './index.less'; | ||
| import * as tmpl from './bodyTemplate.jade'; |
There was a problem hiding this comment.
import bodyTemplate from './body-template.jade';- File name should use kabab-case
- Use don't use short names for globals
js/vnext/projection/column-group.js
Outdated
| }) => { | ||
| const col = { name, width, parent, html, height }; | ||
|
|
||
| const col = { name, width, template, parent, html, height }; |
There was a problem hiding this comment.
All the configurations need to be included:
- headTemplate
- headHtml
- bodyTemplate
- bodyHtml
- footTemplate
- footHtml
|
Changes Unknown when pulling c27225c on lesliekim:master into * on Microsoft:0.1.0-dev*. |
js/vnext/projection/jsdata.js
Outdated
| skip, | ||
| take, | ||
| filter, | ||
| orderby = [], |
| 'config', | ||
| ], function (config) { | ||
| const renderers = []; | ||
| ], function (config) { |
There was a problem hiding this comment.
not intended to change this file?
|
@lesliekim, There's no critical feedbacks, I'll merge the code in. You can fix the comments in a following change. |
lesliekim
pushed a commit
to lesliekim/projection-grid
that referenced
this pull request
Aug 1, 2016
add cells, rows, columns functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.