Skip to content

Fix selection client side error #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix selection client side error #77

wants to merge 2 commits into from

Conversation

wewei
Copy link
Contributor

@wewei wewei commented Nov 8, 2018

Rows without keys are non-selectable. Our selection API setSelectRow need to protect the caller from selecting them.

wewei added 2 commits November 8, 2018 15:29
@wewei
Prevent selecting rows without key
e27e3cd 
Rows without key are non-selectable. The selection API should protect user from doing that.
@wewei
Bump version
d5f583e
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 89.892% when pulling d5f583e on wewei:patch-1 into 465b248 on Microsoft:master.

@ravhb
Copy link
Contributor

ravhb commented Sep 21, 2020

Close the legacy PR.
Will review the change manually.

@ravhb ravhb closed this Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ljqx ljqx ljqx approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wewei @coveralls @ravhb @ljqx