Adding appropriate error message for TestMethods expecting parameters but parameters not provided #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaranigarg
changed the title
singhsarab
reviewed
Jun 27, 2018
| @@ -313,4 +313,7 @@ | |||
| <data name="TestAssembly_AssemblyDiscoveryFailure" xml:space="preserve"> | |||
| <value>Failed to discover tests from assembly {0}. Reason:{1}</value> | |||
| </data> | |||
| <data name="UTA_TestMethodExpectedParameters" xml:space="preserve"> | |||
There was a problem hiding this comment.
Xlf file changes?
@pvlakshm Please review the string
| @@ -143,6 +145,14 @@ internal static string GetAsyncTypeName(this MethodInfo method) | |||
| /// </param> | |||
| internal static void InvokeAsSynchronousTask(this MethodInfo methodInfo, object classInstance, params object[] parameters) | |||
| { | |||
| if (methodInfo.GetParameters() != null && parameters == null) | |||
| { | |||
| string errorMessage = string.Format( | |||
There was a problem hiding this comment.
ResourceManager takes care of culture, do we need this formating?
There was a problem hiding this comment.
Validated on a DEU machine. ResourceManager working expectedly. 👍
| @@ -143,6 +145,14 @@ internal static string GetAsyncTypeName(this MethodInfo method) | |||
| /// </param> | |||
| internal static void InvokeAsSynchronousTask(this MethodInfo methodInfo, object classInstance, params object[] parameters) | |||
| { | |||
| if (methodInfo.GetParameters() != null && parameters == null) | |||
There was a problem hiding this comment.
Please explain the parameters null check
|
@dotnet-bot Test Windows / Debug Build please |
singhsarab
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#199