Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No workbench action to hide panel #14779

Closed
atombender opened this issue Oct 31, 2016 · 8 comments
Closed

No workbench action to hide panel #14779

atombender opened this issue Oct 31, 2016 · 8 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality

Comments

@atombender
Copy link

  • VSCode Version: 1.6.1

There's no editor action to hide the panel. There is only workbench.action.togglePanel, and there's apparently no context so you can do when: "panelVisible" or whatever. So there's no way to bind a key to something that hides the panel.

@rebornix
Copy link
Member

That's cmd+b :)

@atombender
Copy link
Author

Panel, not sidebar.

{ "key": "cmd+j", "command": "workbench.action.togglePanel" },
{ "key": "cmd+b", "command": "workbench.action.toggleSidebarVisibility" },

@atombender
Copy link
Author

(Also, cmd+b also toggles, doesn't hide.)

@atombender
Copy link
Author

@rebornix Want to reopen?

@rebornix
Copy link
Member

rebornix commented Nov 1, 2016

Sorry for the misunderstanding. And yes they share the same problem, no way to directly hide or show. It's a valid request and I think ppl have similar request in #13776 . Let's see if there will be any new API while implement that feature.

@atombender
Copy link
Author

That seems like a different issue: Hide all panels/sidebar. This is just about needing a command.

@rebornix
Copy link
Member

rebornix commented Nov 1, 2016

IMO I think it's not a good idea that just exposing a way to hide everything instead of splitting them into several meaningful commands. But wait and see @isidorn 's input on this and then see if we want to open this issue for tracking.

@isidorn
Copy link
Contributor

isidorn commented Nov 1, 2016

Dup of #14674

@isidorn isidorn reopened this Nov 1, 2016
@isidorn isidorn closed this as completed Nov 1, 2016
@isidorn isidorn added feature-request Request for new features or functionality *duplicate Issue identified as a duplicate of another issue(s) labels Nov 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants