Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility cmd click #69719

Closed
Phuket2 opened this issue Mar 3, 2019 · 7 comments
Closed

Accessibility cmd click #69719

Phuket2 opened this issue Mar 3, 2019 · 7 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues editor-hover Editor mouse hover
Milestone

Comments

@Phuket2
Copy link

Phuket2 commented Mar 3, 2019

To be able to right click a link (instead of cmd-clicking it on Mac) and select an option from the popup menu to open the link. (i.e links in terminal/editor)
This could be a setting as to whether or not this would show up in the menu as I image most people wouldn't need it.

*I used Accessibility in the title as I only have the use one arm.

@rebornix rebornix added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Mar 4, 2019
@rebornix
Copy link
Member

rebornix commented Mar 4, 2019

@Phuket2 thanks for your feedback and the suggestion of having an action in context menu when you right click sounds pretty good.

@Tyriar
Copy link
Member

Tyriar commented Mar 4, 2019

@Phuket2 do you use a standard mouse? I would think a mouse with many buttons (example) would be ideal for this sort of disability so you could bind modifiers to individual buttons? Adding all possible modifiers to the context menu doesn't seem like a great solution as it would only work within VS Code (an OS-level feature would make more sense) and fill the context menu with many actions; ctrl+click, alt+click, shift+click.

@Tyriar
Copy link
Member

Tyriar commented Mar 4, 2019

I'm going to close this by design because:

  • Links are keyboard accessible via the "Open link" command
  • Adding options to the context menu would be a mess and this would only solve the problem for VS Code, not other applications

For the terminal specifically I created a new issue to capture the problem #69795

@Tyriar Tyriar closed this as completed Mar 4, 2019
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 4, 2019
@rebornix
Copy link
Member

rebornix commented Mar 5, 2019

IMO we can add the link to the hover and then users can single click to open the link.

@rebornix rebornix reopened this Mar 5, 2019
@Tyriar
Copy link
Member

Tyriar commented Mar 5, 2019

👍 we would need to allow mousing over the hover then though, I think right now it's a setting?

@rebornix
Copy link
Member

rebornix commented Mar 6, 2019

mouse-over-hover

@Tyriar it's controlled by editor.hover.sticky and by default we can mouse over the hover as shown above.

@rebornix rebornix removed the *duplicate Issue identified as a duplicate of another issue(s) label Mar 6, 2019
@rebornix rebornix added this to the July 2019 milestone Jul 22, 2019
@rebornix
Copy link
Member

From tomorrow's Insiders you should be able to click directly in the hover to follow links

hover-click

@rebornix rebornix added the editor-hover Editor mouse hover label Jul 22, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues editor-hover Editor mouse hover
Projects
None yet
Development

No branches or pull requests

3 participants