Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration.md #111934

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Update configuration.md #111934

merged 2 commits into from
Aug 30, 2023

Conversation

rapopescu16
Copy link
Contributor

Added the information about the limitation for the number of IP addresses that can be added in the staticwebapp.config.json

Added the information about the limitation for the number of IP addresses that can be added in the staticwebapp.config.json
@prmerger-automator
Copy link
Contributor

@rapopescu16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit cbaff69:

✅ Validation status: passed

File Status Preview URL Details
articles/static-web-apps/configuration.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Jul 10, 2023

@craigshoemaker

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@thomasgauvin
Copy link
Contributor

I am ok adding this to the configuration article. Note that this is already included in the quotas table https://learn.microsoft.com/en-us/azure/static-web-apps/quotas, so perhaps we should refer to that as the single source of truth @craigshoemaker

@rapopescu16
Copy link
Contributor Author

I am ok adding this to the configuration article. Note that this is already included in the quotas table https://learn.microsoft.com/en-us/azure/static-web-apps/quotas, so perhaps we should refer to that as the single source of truth @craigshoemaker

to be honest, the reason why I created the PR was because we had multiple customers not finding the limitation. (at least 4).

@thomasgauvin
Copy link
Contributor

I am ok adding this to the configuration article. Note that this is already included in the quotas table https://learn.microsoft.com/en-us/azure/static-web-apps/quotas, so perhaps we should refer to that as the single source of truth @craigshoemaker

to be honest, the reason why I created the PR was because we had multiple customers not finding the limitation. (at least 4).

I definitely understand that, that is why I recommend pointing folks to the quotas table. That table does a good job of listing the limitations for each SKU

@craigshoemaker
Copy link
Contributor

Agreed. I like how you're trying to surface the limitations better, @rapopescu16! Let's go with the link to the quotas page to make sure we don't have changes that get out of sync.

Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
@rapopescu16
Copy link
Contributor Author

done, sorry totally missed it. :(

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 0e6601d:

✅ Validation status: passed

File Status Preview URL Details
articles/static-web-apps/configuration.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@American-Dipper
Copy link
Contributor

@craigshoemaker - is this ready for merge? Thanks.

@craigshoemaker
Copy link
Contributor

#sign-off

@Jak-MS Jak-MS merged commit fc57fb8 into MicrosoftDocs:main Aug 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants