-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration.md #111934
Update configuration.md #111934
Conversation
Added the information about the limitation for the number of IP addresses that can be added in the staticwebapp.config.json
@rapopescu16 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit cbaff69: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? When the changes are ready for publication, add a #label:"aq-pr-triaged" |
I am ok adding this to the configuration article. Note that this is already included in the quotas table https://learn.microsoft.com/en-us/azure/static-web-apps/quotas, so perhaps we should refer to that as the single source of truth @craigshoemaker |
to be honest, the reason why I created the PR was because we had multiple customers not finding the limitation. (at least 4). |
I definitely understand that, that is why I recommend pointing folks to the quotas table. That table does a good job of listing the limitations for each SKU |
Agreed. I like how you're trying to surface the limitations better, @rapopescu16! Let's go with the link to the quotas page to make sure we don't have changes that get out of sync. |
Co-authored-by: Thomas Gauvin <35609369+thomasgauvin@users.noreply.github.com>
done, sorry totally missed it. :( |
Learn Build status updates of commit 0e6601d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@craigshoemaker - is this ready for merge? Thanks. |
#sign-off |
Added the information about the limitation for the number of IP addresses that can be added in the staticwebapp.config.json