Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update durable-functions-error-handling.md #64108

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

dannyb648
Copy link
Contributor

@dannyb648 dannyb648 commented Oct 9, 2020

Currently not able to pass in a Custom Error Handle in the Typescript runtime, however this isnt clear in the documentation. Happy to revise the new note into a better format.

Currently not able to pass in a Custom Error Handle in the Typescript runtime, however this isnt clear in the documentation. Happy to revise the new note int oa better format.
@PRMerger14
Copy link
Contributor

@dannyb648 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger16
Copy link
Contributor

@dannyb648 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dannyb648
Copy link
Contributor Author

dannyb648 commented Oct 9, 2020

Azure/azure-functions-durable-js#103 This is the issue where MS state this functionality isnt implemented yet

@ktoliver ktoliver added the aq-pr-triaged tracking label for the PR review team label Oct 9, 2020
Copy link
Contributor

@ggailey777 ggailey777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please accept my edits and we'll get this merged.

@ggailey777
Copy link
Contributor

@dannyb648 thanks for the help documenting this!

…ing.md

Co-authored-by: Glenn Gailey <ggailey777@hotmail.com>
@PRMerger19
Copy link
Contributor

@dannyb648 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@dannyb648
Copy link
Contributor Author

dannyb648 commented Dec 17, 2020

Merged Accepted from me, thanks guys for the better wording!

@ggailey777
Copy link
Contributor

@dannyb648 thanks again for the help with our docs #sign-off

@PRMerger17
Copy link
Contributor

@ggailey777: I'm sorry - only the author of this article, @, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@cgillum
Copy link
Contributor

cgillum commented Dec 17, 2020

#sign-off

@PRMerger9
Copy link
Contributor

@cgillum: I'm sorry - only the author of this article, @ggailey777, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ggailey777
Copy link
Contributor

I should be able to #sign-off on this PR.

@ktoliver ktoliver merged commit 879c8da into MicrosoftDocs:master Dec 17, 2020
@ktoliver
Copy link
Contributor

I should be able to #sign-off on this PR.

Bug opened for PRMerger issues when the author metadata attribute is set globally in a separate file: https://ceapex.visualstudio.com/Engineering/_workitems/edit/349218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants