Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update article "Emulate and test other browsers" #3210

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Update article "Emulate and test other browsers" #3210

merged 8 commits into from
Jul 18, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Jun 28, 2024 •
edited
Loading

@mikehoffms mikehoffms added the cat: devtools DevTools-related content. label Jun 28, 2024
@mikehoffms mikehoffms marked this pull request as ready for review July 16, 2024 23:22
bwalderman
bwalderman approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@bwalderman bwalderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

microsoft-edge/devtools-guide-chromium/device-mode/testing-other-browsers.md Outdated Show resolved Hide resolved
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit bdc447f:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/device-mode/testing-other-browsers.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 5e2dc87:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/device-mode/testing-other-browsers.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit c4b4863 into main Jul 18, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/mikehoffms/update-emulate branch July 18, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwalderman bwalderman bwalderman approved these changes

@captainbrosset captainbrosset captainbrosset approved these changes

@zoherghadyali zoherghadyali Awaiting requested review from zoherghadyali

Assignees
No one assigned
Labels
cat: devtools DevTools-related content. in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikehoffms @captainbrosset @bwalderman