Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Microsoft Search in Bing" in "Address bar" section of Privacy #3224

Merged
merged 22 commits into from
Jul 24, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Jul 12, 2024

Rendered article section for review:

Changes made in this PR:

  • Added Microsoft Search in Bing h4 subsection in the Address bar and suggestions h2 section.
  • Did a 50% thorough copyedit in entire "Address bar and suggestions" h2 section.
  • Did a 75% thorough structural edit in entire "Address bar and suggestions" h2 section (ie added h4 headings).
  • Trimmed trailing whitespace in entire article.
  • In one spot in unrelated h2 section, changed from "To do x, do the following:" to "To do x:"
  • In entire article, normalized: above each subheading (h4), html comment divider 40 char wide.
  • In repo, consistently wrote title as "Microsoft Edge Privacy Whitepaper".

AB#52464669

Copy link
Contributor Author

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM.
to expedite this update, hidden todo comments (from broad review of entire h2 section) are to be fixed later, after move article to other repo.

microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
microsoft-edge/privacy-whitepaper/index.md Outdated Show resolved Hide resolved
Copy link

Learn Build status updates of commit 25f254f:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/develop-web-microsoft-edge.md ✅Succeeded View
microsoft-edge/docfx.json ✅Succeeded
microsoft-edge/index.yml ✅Succeeded View
microsoft-edge/privacy-whitepaper/index-images/delete-history-for-a-search-suggestion.png ✅Succeeded View
microsoft-edge/privacy-whitepaper/index-images/search-suggestions-typed-chars.png ✅Succeeded View
microsoft-edge/privacy-whitepaper/index.md ✅Succeeded View
microsoft-edge/toc.yml ✅Succeeded View
microsoft-edge/webdriver-chromium/index.md ✅Succeeded View
microsoft-edge/webview2/concepts/data-privacy.md ✅Succeeded View
microsoft-edge/webview2/concepts/overview-features-apis.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@apryzgoda apryzgoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge Privacy Champ approved

@zoherghadyali zoherghadyali merged commit 7506a5f into main Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants