-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Problem/Bug]: New windows open when it shouldn't #4224
Comments
We are also facing the same issue. Please help. |
We are currently looking into this issue |
Thank you :) |
@victorhuangwq is this considered a regression or is it still being looked into? |
@victorhuangwq just reporting that this is still happening on runtime 120.0.2210.77 |
Same issue here suddenly due to some update on Edge since 120.0.2210.61 the new window events aren't cancelled with e.NewWindow = webView21.CoreWebView2;. I've been running the code for 2 years already without issues until now. |
For now, I have been forced to turn my 2mb install size into close to 500mb install while I include the runtime to fix the issue. |
Closing the issue as duplicate of #4250 |
From the issue description, this may potentially be a distinct issue from #4250 as IIUC you are expecting WebView to ignore the NewWindowRequest with this code snippet so I'm reopening this issue to clarify. In the snippet, if the URL is a specific URL(contains However, in other cases, you are setting Does this match your expectation? |
@yildirimcagri-msft I'm back on deck after having 3 weeks off. So in a nutshell if the url contains powerapps I do not want a new window to open while for all other requests, open a new window. I just checked with runtime 120.0.2210.133 and it's working the way it should now. |
What happened?
I'm not sure what happens, we been running the same custom built app for months with no code changes and now our logic that tells webview2 to ignore any requests to open a new browser window isn't working.
Importance
Moderate. My app's user experience is affected, but still usable.
Runtime Channel
Stable release (WebView2 Runtime)
Runtime Version
120.0.2210.61
SDK Version
1.0.2151.40
Framework
WPF
Operating System
Windows 10
OS Version
No response
Repro steps
Use the following code (change URL etc as need be:
And attach it to the
WebView.CoreWebView2.NewWindowRequested
event.Repros in Edge Browser
Not Applicable
Regression
Regression in newer Runtime
Last working version (if regression)
Runtime 119.0.2151.97 (I think)
The text was updated successfully, but these errors were encountered: