Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor housekeeping #1

Merged
merged 4 commits into from
Dec 21, 2020
Merged

Minor housekeeping #1

merged 4 commits into from
Dec 21, 2020

Conversation

alanvardy
Copy link
Contributor

Hi @MikaAK

Thank you for the library, I am starting this for some easy wins and will hopefully follow up with some specs if I can make heads or tails of what is going on with my dialyzer!

Cheers 🙂

@alanvardy alanvardy requested a review from MikaAK February 9, 2020 00:33
Comment on lines -3 to +4
#### V0.1.0
- Initial Release

#### V0.1.1
- Add some documentation fixes
#### V0.1.5
- Add `find_or_create` for Actions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reversed the order of your changelog, not sure on what you personal preference is. I got the changes from your commit history.

Comment on lines 12 to 15
[
{:ecto_shorts, "~> 0.1.0"}
{:ecto_shorts, "~> 0.1.5"}
]
end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this is the right call, of course using 0.1.0 works all the way up until you release 0.2.0

@MikaAK MikaAK merged commit a184e03 into MikaAK:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants