Several small additions/tweaks #14
Conversation
mayel
changed the title
| #### WIP | ||
| - Added support for passing ecto `dynamic` filters | ||
| - Added support for passing functions to use for custom filtering | ||
| - Added `EctoShorts.filter` as a shortcut to `CommonFilters.convert_params_to_filter` |
There was a problem hiding this comment.
Think this is redundant and wouldn't add this in
| - Added support for passing ecto `dynamic` filters | ||
| - Added support for passing functions to use for custom filtering | ||
| - Added `EctoShorts.filter` as a shortcut to `CommonFilters.convert_params_to_filter` | ||
| - Added a default order_by field and direction for queries |
There was a problem hiding this comment.
Default ordering shouldn't exist, this can cause performance issues, also the direction has a default naturally, the order param was actually removed because of this, instead you can now specify %{order_by: :field} or %{order_by: [asc: :field]}
| - Added support for passing functions to use for custom filtering | ||
| - Added `EctoShorts.filter` as a shortcut to `CommonFilters.convert_params_to_filter` | ||
| - Added a default order_by field and direction for queries | ||
| - Added `:id` to common filters |
There was a problem hiding this comment.
This shouldn't be necessary, :id if a valid field on the schema will get run through the schema filters and be put in
| MIT | ||
|
|
||
| - Copyright 2020 Mika Kalathil | ||
| - Copyright 2021 Bonfire contributors |
| @@ -1,5 +1,13 @@ | |||
| ## Changelog | |||
|
|
|||
| #### WIP | |||
| - Added support for passing ecto `dynamic` filters | |||
| - Added support for passing functions to use for custom filtering | |||
There was a problem hiding this comment.
I don't think you should do this, ultimately this is why the first parameter is a query and can be passed in, because you can add custom filtering there
|
Going to close this as it's gotten pretty stale, feel free to re-open if needed! |
As discussed here's a PR with some changes I made while using EctoShorts for Bonfire :)
dynamicfiltersEctoShorts.filteras a shortcut toEctoShorts.CommonFilters.convert_params_to_filter:idto common filters