Build array filter

[hlista]

Changes to query builder to handle an array field in a schema.

Currently EctoShorts handles conversions the following way when dealing with an array field
CommonFilters.convert_params_to_filter(User, %{array_field: :value}) =>
from u0 in Schemas.User, where: u0.array_field == ^:value, select: u0

CommonFilters.convert_params_to_filter(User, %{array_field: [:value]}) =>
from u0 in Schemas.User, where: u0.array_field in ^[:value], select: u0

Both of which error out

Now EctoShorts will do the following conversions

CommonFilters.convert_params_to_filter(User, %{array_field: :value}) =>
from u0 in Schemas.User, where: ^:value in u0.array_field, select: u0

CommonFilters.convert_params_to_filter(User, %{array_field: [:value]}) =>
from u0 in Schemas.User, where: u0.array_field == ^[:value], select: u0

[MikaAK]

What's the behaviour here? If it's a map what happens?

[hlista]

This is to ensure standard filter behaviour. If a map is passed we send the call to build where the is_map guard will pick it up and do the standard build_subfield_filter reduce.

This is to ensure we can still make calls to check if the field is {:==, nil}, {:!=, nil}, {:!=, val}

[MikaAK]

How does the current code handle this? And how would it need to change since the code that previously did this will no longer be doing this from what I gather? Should we change the method name to reflect that it's not just buliding and array?

[hlista]

So this is preserving the behaviour of the current code
CommonFilters.convert_params_to_filter(User, %{array_field: %{!=: nil}})
in the current code this would go to the build function and get picked up by the is_map guard

[MikaAK]

Okay cool! Looks good!