Request/Feat: Sanitize string id keys before find, update, and delete actions #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm requesting we add a fallback to sanitize string ID keys before the find, update, and delete actions.
It removes overhead from a common use case where the data is sent from a controller to the EctoShorts.Actions making it easier to use out of the box
In the event the 'ID' is not the correct type the wrong EctoShorts.Actions action function will be called. The error message it outputs due to this doesn't make it clear this is why it fails. Eg: Here the changeset function was expecting a schema and instead got passed the ID as a string because currently
EctoShorts.Actions .update()
for eg only handles ints, and lists and therefore tried applying an update call with the wrong params.This catches those fall through cases and makes it clear the type of 'ID' trying to be inserted into a table must explicitly match the type of 'ID' in the table which is of type INT/integer