Fix compilation issues

[brookst]

I had to fix a broken dev-dependency to get this compiling. I fixed up the tests to work with assert_cli and a minor issue with the benchmarks. The benchmarks look like they take a very long time to run so I've not run them through.

[brookst]

Well Linux and Windows work. I don't really know what's happening with the BSD tests.

On FreeBSD the error is:

     Running /target/x86_64-unknown-freebsd/debug/deps/img_diff-0b0d51874f79e4db
error: could not execute process `/target/x86_64-unknown-freebsd/debug/deps/img_diff-0b0d51874f79e4db` (never executed)
Caused by:
  No such file or directory (os error 2)

I can't find anything about that online.

Whereas NetBSD gives this mess:

error: linking with `x86_64-unknown-netbsd-gcc` failed: exit code: 1
  |
  = note: "x86_64-unknown-netbsd-gcc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-m64" "-L" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5.1im38lueib99jsk0.rcgu.o" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5.3ayaeypdcro9d6yk.rcgu.o" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5.3rngp6bm2u2q5z0y.rcgu.o" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5.4b8ptp1vn215jmoe.rcgu.o" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5.57i1ma1yyeq0e14o.rcgu.o" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5.8xzrsc1ux72v29j.rcgu.o" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5.9elsx31vb4it187.rcgu.o" "-o" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5" "/target/x86_64-unknown-netbsd/debug/deps/img_diff-2a358f2b2ac0cfb5.crate.allocator.rcgu.o" "-Wl,--gc-sections" "-pie" "-Wl,-z,relro,-z,now" "-Wl,-O1" "-nodefaultlibs" "-L" "/target/x86_64-unknown-netbsd/debug/deps" "-L" "/target/debug/deps" "-L" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib" "-Wl,-Bstatic" "/target/x86_64-unknown-netbsd/debug/deps/libimg_diff-e203622fe4df44aa.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libbmp-6a91370a035f8087.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libbyteorder-c963b2eecca8fe00.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libdssim-8e5417565bb637ca.rlib" "/target/x86_64-unknown-netbsd/debug/deps/liblodepng-ed94cf858e8aa486.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libitertools-4c78ae8835a3419f.rlib" "/target/x86_64-unknown-netbsd/debug/deps/librayon-114873d60b228de7.rlib" "/target/x86_64-unknown-netbsd/debug/deps/librayon_core-9d0166a8eceba8a1.rlib" "/target/x86_64-unknown-netbsd/debug/deps/librand-00eda7b6d101eaf3.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libnum_cpus-fc1cbe3d685c2712.rlib" "/target/x86_64-unknown-netbsd/debug/deps/liblibc-a74cd9fb8e363f90.rlib" "/target/x86_64-unknown-netbsd/debug/deps/liblazy_static-b52eab3d5c8500fc.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libcoco-c2ee9313a939c5a7.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libscopeguard-035aa302876ddcae.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libeither-6d6caad8055889f9.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libimgref-f617a90101c8d0f7.rlib" "/target/x86_64-unknown-netbsd/debug/deps/librgb-33d472d23291e3a2.rlib" "/target/x86_64-unknown-netbsd/debug/deps/libgetopts-b03d6c103238775f.rlib" "-Wl,--start-group" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib/libstd-9a440ef90899818f.rlib" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib/libpanic_unwind-7bed87070cafeede.rlib" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib/libunwind-8cd3b0417a81fb26.rlib" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib/liballoc_system-387bd949d1b36a91.rlib" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib/liblibc-453d825a151d7dec.rlib" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib/liballoc-5235bf36189564a3.rlib" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib/libcore-5725e7f9b84bd931.rlib" "-Wl,--end-group" "/rust/lib/rustlib/x86_64-unknown-netbsd/lib/libcompiler_builtins-874d313336916306.rlib" "-Wl,-Bdynamic" "-l" "util" "-l" "pthread" "-l" "gcc_s" "-l" "m" "-l" "util" "-l" "util"
  = note: /usr/local/lib/gcc/x86_64-unknown-netbsd/5.3.0/../../../../x86_64-unknown-netbsd/bin/ld: /rust/lib/rustlib/x86_64-unknown-netbsd/lib/libstd-9a440ef90899818f.rlib(std-9a440ef90899818f.std4-ba033d55066f959f3c60fd22b4444f22.rs.rcgu.o): undefined reference to symbol 'execvp'
          /usr/local/x86_64-unknown-netbsd/lib/libc.so.12: error adding symbols: DSO missing from command line
          collect2: error: ld returned 1 exit status
      
error: aborting due to previous error

Googling around only gives this mention that it might be to do with build.rs which is needed to get cargo to create $OUT_DIR.

[Mike-Neto]

Great, this used a fork i made from assert_cli that had regex support.
I'm merging this for now I will try and find some time to see what is going on with BSD or try to make testing less flaky.

[brookst]

Yeah, I posted to japaric/trust#101 that we hit this error even without a build.rs (which was a bit of a red herring). I have no idea what would make NetBSD different to FreeBSD - I haven't used either. It looks like people are just disabling NetBSD on Travis (or moving it to allow_failures) for the time being.