Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-255: Fix runtest.cmd to run GdUnitCopyLog in headless mode #252

Merged
merged 2 commits into from
Sep 14, 2023
Merged

GD-255: Fix runtest.cmd to run GdUnitCopyLog in headless mode #252

merged 2 commits into from
Sep 14, 2023

Conversation

LinuxUserGD
Copy link
Contributor

@LinuxUserGD LinuxUserGD commented Sep 8, 2023

Why

The 'runtest.cmd' scripts still contains the '--no-window' argument where is changed with Godot4 to --headless

What

Use --headless argument to execute GdUnitCopyLog in headless mode

Copy link
Owner

@MikeSchulze MikeSchulze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running test with --headless mode is actually not supported, see my comments

addons/gdUnit4/runtest.cmd Show resolved Hide resolved
addons/gdUnit4/runtest.sh Outdated Show resolved Hide resolved
Copy link
Owner

@MikeSchulze MikeSchulze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LinuxUserGD I have created a new bug issue to assign to this problem

@MikeSchulze MikeSchulze linked an issue Sep 13, 2023 that may be closed by this pull request
@MikeSchulze MikeSchulze changed the title GD-249: runtest: Add --headless cmdline arg GD-249: Fix GdUnitCopyLog to run headless Sep 14, 2023
@MikeSchulze MikeSchulze changed the title GD-249: Fix GdUnitCopyLog to run headless GD-255: Fix 'runtest.cmd' to run GdUnitCopyLog in headless mode Sep 14, 2023
@MikeSchulze MikeSchulze changed the title GD-255: Fix 'runtest.cmd' to run GdUnitCopyLog in headless mode GD-255: Fix runtest.cmd to run GdUnitCopyLog in headless mode Sep 14, 2023
@MikeSchulze MikeSchulze self-requested a review September 14, 2023 17:56
@MikeSchulze MikeSchulze merged commit 976d908 into MikeSchulze:master Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GD-255: The runtest.cmd uses outdated --no-window and do not run the GdUnitCopyLog in headless mode
2 participants