Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both net7 and net8 at once #61

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Conversation

van800
Copy link
Contributor

@van800 van800 commented Mar 11, 2024

I had only net8 installed, so I had to make some changes to allow both net7 and net8

@MikeSchulze MikeSchulze merged commit cf0f97e into MikeSchulze:master Mar 11, 2024
@MikeSchulze MikeSchulze self-requested a review March 11, 2024 15:04
Copy link
Owner

@MikeSchulze MikeSchulze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you made it

@MikeSchulze
Copy link
Owner

hm, with .Net8 the test adapter breaks in VSCode
I'll have to take a look at why this no longer works with .NET8

@van800
Copy link
Contributor Author

van800 commented Mar 11, 2024

This actually doesn't block me now, you may just revert the whole pull request, if you feel like. I wanted to help, not to create additional work for you.

@MikeSchulze
Copy link
Owner

MikeSchulze commented Mar 11, 2024

I found the issue, the projects using Godot do not separate the build output for .NET7 and .NET8, it saves just to .godot
I set the default for this project to .NET8 now and it works

But with .NET8 a lot of new warnings pops up and needs to be fixed as well.
I'm actual working on it, but thanks for your preparing ;)

Continue here -> #63

@MikeSchulze
Copy link
Owner

Perhaps you have an idea where these warnings come from

CSC : warning AD0001: Analyzer 'Godot.SourceGenerators.MustBeVariantAnalyzer' threw an exception of type 'System.NullReferenceException' with message 'Object reference not set to an instance of an object.'. [/home/runner/work/gdUnit4Mono/gdUnit4Mono/test/gdUnit4Test.csproj::TargetFramework=net8.0]

@van800
Copy link
Contributor Author

van800 commented Mar 11, 2024

It is from the Godot sources, however I don't know much
https://github.com/godotengine/godot/issues?q=AD0001%3A+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants