Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter Email Message Default Policy to Comply With RFC 5322 #75

Merged
merged 23 commits into from
Feb 21, 2023

Conversation

Waghabond
Copy link
Contributor

The Python email library's default policy does not fully comply with the Internet mail standard.
So this will alter the default policy when it is used by redmail so that the email messages it creates will comply with the internet standards and be more likely to be displayed correctly by all email clients.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Base: 99.68% // Head: 99.68% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a9f77b2) compared to base (a813ac1).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #75   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          13       13           
  Lines         627      636    +9     
=======================================
+ Hits          625      634    +9     
  Misses          2        2           
Impacted Files Coverage Δ
redmail/email/body.py 100.00% <100.00%> (ø)
redmail/email/sender.py 100.00% <100.00%> (ø)
redmail/email/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Miksus
Copy link
Owner

Miksus commented Feb 19, 2023

Thanks for fixing this! You are indeed correct:

2.3. Body
The body of a message is simply lines of US-ASCII characters. The
only two limitations on the body are as follows:
o CR and LF MUST only occur together as CRLF; they MUST NOT appear
independently in the body.

(https://www.rfc-editor.org/rfc/rfc5322)

I'll add to the versions.rst about this later today or tomorrow and then I think we can merge this.

@Miksus
Copy link
Owner

Miksus commented Feb 21, 2023

Whops, it seems I spaghettified the PR by working with the same workspace as with the other PR...

But I think this is good.

@Miksus Miksus merged commit 8511afc into Miksus:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants