Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/force run params #101

Merged
merged 19 commits into from
Sep 17, 2022
Merged

Dev/force run params #101

merged 19 commits into from
Sep 17, 2022

Conversation

Miksus
Copy link
Owner

@Miksus Miksus commented Sep 17, 2022

This has several updates:

  • New argument classes: EnvArg, CliArg
  • Arguments can be piped using >>. The first that does not raise an error is used.
  • Tasks can be set running using task.run() and it supports passing run parameters
  • Deprecated task.force_run
  • Now parameter passing is more consistent under the hood

@Miksus Miksus added bug Something isn't working enhancement New feature or request core Relates to the core functionalities (ie. base classes) labels Sep 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Base: 95.19% // Head: 95.49% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (746f7d5) compared to base (e29db97).
Patch coverage: 96.52% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   95.19%   95.49%   +0.30%     
==========================================
  Files          88       88              
  Lines        4474     4597     +123     
==========================================
+ Hits         4259     4390     +131     
+ Misses        215      207       -8     
Impacted Files Coverage Δ
rocketry/core/task.py 93.36% <94.59%> (+0.01%) ⬆️
rocketry/tasks/func.py 96.02% <95.23%> (+0.92%) ⬆️
rocketry/core/parameters/arguments.py 97.29% <95.65%> (+22.29%) ⬆️
rocketry/args/builtin.py 98.49% <98.33%> (+4.82%) ⬆️
rocketry/args/__init__.py 100.00% <100.00%> (ø)
rocketry/core/parameters/parameters.py 97.93% <100.00%> (+0.04%) ⬆️
rocketry/conditions/task/task.py 92.65% <0.00%> (+0.68%) ⬆️
rocketry/conditions/api.py 98.62% <0.00%> (+1.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Miksus Miksus merged commit ae7ae3f into master Sep 17, 2022
@Miksus Miksus deleted the dev/force_run_params branch September 17, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Relates to the core functionalities (ie. base classes) enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants