Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scientific notation #110

Merged
merged 19 commits into from
May 11, 2024
Merged

Scientific notation #110

merged 19 commits into from
May 11, 2024

Conversation

Mikuana
Copy link
Owner

@Mikuana Mikuana commented May 7, 2024

Adding number field type with optional parameter to allow scientific notation.

Adding tests
Adding latest pythons and removing mac-os because it's
complaining. `Version 3.7 with arch x64 not found`
Build treated this as 3.1
@Mikuana Mikuana marked this pull request as draft May 7, 2024 18:54
@Mikuana Mikuana requested a review from Snotpus May 7, 2024 18:54
@Mikuana Mikuana added the enhancement New feature or request label May 7, 2024
@Mikuana
Copy link
Owner Author

Mikuana commented May 7, 2024

@Snotpus I'm having trouble with the automated build tests. Windows Python 3.11 failed because of a file access issue. I seem to recall you did something to fix that? Was it a delay or something? It's weird because all the other ones worked.

Here's the run data

@Mikuana Mikuana linked an issue May 7, 2024 that may be closed by this pull request
So this field gets brought in with others on a
* import.
Required to build.
@Mikuana Mikuana marked this pull request as ready for review May 8, 2024 05:06
@Mikuana Mikuana self-assigned this May 8, 2024
Jacob Campbell and others added 11 commits May 10, 2024 11:46
We don't really care about the details of why this isn't working I don't think. Our runner is ephemeral so who cares if something goes weird with the test cleanup?
I couldn't replicate this locally at all (something specific to the runner?).

I eventually found this [pytest issue](pytest-dev/pytest#7491) that discusses
similar(ish) behaviors. This lead me to attempt to catch the PermissionError exception and essentially ignore it.

I'm not sure if this is a good approach, but it appears to resolve the issue.

Co-authored-by: Jacob Campbell <jacob.campbell@hca.wa.gov>
@Mikuana Mikuana merged commit a66f210 into dev May 11, 2024
12 checks passed
@Mikuana Mikuana deleted the scientific-notation branch May 11, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revise NumericDecimals regex to handle scientific notation?
2 participants