Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): Add opencontainers image-spec to Dockerfile #166

Merged
merged 3 commits into from
Jul 17, 2022
Merged

feat(docker): Add opencontainers image-spec to Dockerfile #166

merged 3 commits into from
Jul 17, 2022

Conversation

SauravMaheshkar
Copy link
Contributor

This PR makes a few tiny changes to improve the overall quality of the docker image 🐳 . For reference more annotations can be found here

This PR makes a few tiny changes to improve the overall quality of the docker image 🐳 . For reference more annotations can be found [here](https://github.com/opencontainers/image-spec/blob/main/annotations.md)
@MilesCranmer
Copy link
Owner

Thanks! Is there a way to make org.opencontainers.image.version pull from version.py, so it doesn't need to be manually updated?

@MilesCranmer MilesCranmer self-requested a review July 17, 2022 20:15
@SauravMaheshkar
Copy link
Contributor Author

Thanks! Is there a way to make org.opencontainers.image.version pull from version.py, so it doesn't need to be manually updated?

Interesting suggestion, maybe we could make it to be another ARG that is then passed as a --build-arg ?

@MilesCranmer
Copy link
Owner

That sounds good to me.

@MilesCranmer MilesCranmer merged commit 93cf05b into MilesCranmer:master Jul 17, 2022
@SauravMaheshkar SauravMaheshkar deleted the patch-1 branch July 17, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants