Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: πŸ› list item can have other block as first children #1300

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

Saul-Mirone
Copy link
Member

βœ… Closes: #1276

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

Allow list item to have other types of block as first child.

How did you test this change?

CI

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
milkdown-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 6, 2024 9:29am

Copy link

nx-cloud bot commented Apr 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit df46f50. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 3 targets

Sent with πŸ’Œ from NxCloud.

@Saul-Mirone Saul-Mirone enabled auto-merge (squash) April 6, 2024 09:33
@Saul-Mirone Saul-Mirone merged commit 5bc11d4 into main Apr 6, 2024
14 checks passed
Copy link

cypress bot commented Apr 6, 2024

Passing run #767 β†—οΈŽ

0 83 0 0 Flakiness 0

Details:

Merge df46f50 into d408214...
Project: Default Project Commit: 76347490f8 ℹ️
Status: Passed Duration: 01:41 πŸ’‘
Started: Apr 6, 2024 9:32 AM Ended: Apr 6, 2024 9:33 AM

Review all test suite changes for PR #1300 β†—οΈŽ

@Saul-Mirone Saul-Mirone deleted the fix-list-item-content branch April 6, 2024 09:34
Copy link

cypress bot commented Apr 6, 2024

Passing run #769 β†—οΈŽ

0 83 0 0 Flakiness 0

Details:

fix: πŸ› list item can have other block as first children (#1300)
Project: Default Project Commit: 5bc11d4690
Status: Passed Duration: 01:51 πŸ’‘
Started: Apr 6, 2024 9:36 AM Ended: Apr 6, 2024 9:38 AM

Review all test suite changes for PR #1300 β†—οΈŽ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][preset-commonmark] Unable to use non-paragraph elements as the first element inside a list item
1 participant