Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 optimize table dnd behavior #1487

Merged
merged 4 commits into from
Aug 25, 2024
Merged

Conversation

Saul-Mirone
Copy link
Member

  • I read the contributing guide
  • I agree to follow the code of conduct

Summary

The previous implementation is too aggressive on deciding next cell position.

How did you test this change?

CI and Manually

Copy link

changeset-bot bot commented Aug 25, 2024

🦋 Changeset detected

Latest commit: fb49f10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@milkdown/components Patch
@milkdown/crepe Patch
@milkdown/kit Patch
@milkdown/storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
milkdown-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 8:25am

Copy link

nx-cloud bot commented Aug 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fb49f10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Saul-Mirone Saul-Mirone merged commit 56af3f5 into main Aug 25, 2024
4 checks passed
@Saul-Mirone Saul-Mirone deleted the optimize-table-drag-behavior branch August 25, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant