Replay attacks test develop #10619
Merged
Replay attacks test develop #10619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuiteStochastic
added
the
ci-build-me
deepthiskumar
requested changes
Mar 25, 2022
| ; { balance = "10000" | ||
| ; timing = | ||
| make_timing ~min_balance:1_000_000_000_000 ~cliff_time:8 | ||
| make_timing ~min_balance:10_000_000_000_000 ~cliff_time:8 |
There was a problem hiding this comment.
Is this ok? I believe the timing test (which is currently failing) depends on these values
There was a problem hiding this comment.
ah i am tinkering with this at the moment, i'll get it passing. as long as it's passing you don't mind if i jack up the values do you? I'm just trying to increase the values to that coinbases stop messing with my math.
There was a problem hiding this comment.
Ah ok, that's fine. You could use the new extra_genesis_accounts field in test config and not deal with coinbase amounts
There was a problem hiding this comment.
oh that's a good idea, maybe in a different PR tho
deepthiskumar
approved these changes
Mar 26, 2022
…_attacks_test_DEVELOP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same thing as #10463 but merge into develop. there are a couple of things that are different so beware