-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replay attacks test develop #10619
Replay attacks test develop #10619
Conversation
; { balance = "10000" | ||
; timing = | ||
make_timing ~min_balance:1_000_000_000_000 ~cliff_time:8 | ||
make_timing ~min_balance:10_000_000_000_000 ~cliff_time:8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ok? I believe the timing test (which is currently failing) depends on these values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i am tinkering with this at the moment, i'll get it passing. as long as it's passing you don't mind if i jack up the values do you? I'm just trying to increase the values to that coinbases stop messing with my math.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, that's fine. You could use the new extra_genesis_accounts
field in test config and not deal with coinbase amounts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh that's a good idea, maybe in a different PR tho
…_attacks_test_DEVELOP
same thing as #10463 but merge into develop. there are a couple of things that are different so beware