Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breadcrumb wait for not working #10702

Merged
merged 9 commits into from
Apr 8, 2022
Merged

breadcrumb wait for not working #10702

merged 9 commits into from
Apr 8, 2022

Conversation

QuiteStochastic
Copy link
Contributor

@QuiteStochastic QuiteStochastic commented Apr 5, 2022 •
edited
Loading

this PR addresses both #10721 and #10699

after merging, intg tests should be a lot less flaky in general, as well as gossip-consistency itself being less flaky

@QuiteStochastic QuiteStochastic requested a review from a team as a code owner April 5, 2022 08:15
@QuiteStochastic QuiteStochastic added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Apr 6, 2022
@QuiteStochastic QuiteStochastic changed the base branch from develop to compatible April 6, 2022 01:58
nholland94
nholland94 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@nholland94 nholland94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but have some simple nits that I would like addressed before merging.

src/lib/integration_test_lib/network_state.ml Outdated Show resolved Hide resolved
src/lib/integration_test_lib/network_state.ml Outdated Show resolved Hide resolved
@QuiteStochastic QuiteStochastic mentioned this pull request Apr 8, 2022
Merged
@QuiteStochastic QuiteStochastic merged commit 763cc27 into compatible Apr 8, 2022
@QuiteStochastic QuiteStochastic deleted the breadcrumb_wait_for branch April 8, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nholland94 nholland94 nholland94 approved these changes

Assignees
No one assigned
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuiteStochastic @nholland94