Lint for multiple versioned types in module #11121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteckler
requested review from
bkase,
imeckler,
mrmr1993 and
a team
as code owners
psteckler
added
the
ci-build-me
This was referenced May 27, 2022
lk86
approved these changes
May 27, 2022
mrmr1993
approved these changes
May 27, 2022
mrmr1993
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versioned type linter was detecting changes to at most one type in a module, because the Python script builds a dictionary where the key was a module path printed by
print_versioned_types. That tool relies on the printer invoked byderiving version.That mean that changes to
querytypes in RPC modules were not being detected in CI; the dictionary entry was overwritten with an entry for theresponsetype.Modify the printer to append the type to the module path.