Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snarkyjs assertion long forms #12494

Merged
merged 7 commits into from
Jan 18, 2023
Merged

snarkyjs assertion long forms #12494

merged 7 commits into from
Jan 18, 2023

Conversation

Trivo25
Copy link
Member

@Trivo25 Trivo25 commented Jan 11, 2023

companion of o1-labs/o1js#681

@Trivo25 Trivo25 requested review from a team, imeckler and mrmr1993 as code owners January 11, 2023 09:34
@Trivo25
Copy link
Member Author

Trivo25 commented Jan 11, 2023

!ci-build-me

@Trivo25
Copy link
Member Author

Trivo25 commented Jan 17, 2023

!ci-build-me

@Trivo25 Trivo25 mentioned this pull request Jan 17, 2023
Merged
@Trivo25
Copy link
Member Author

Trivo25 commented Jan 18, 2023

!ci-build-me

mitschabaude
mitschabaude requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the assertBool change

@Trivo25
Copy link
Member Author

Trivo25 commented Jan 18, 2023

This is missing the assertBool change

Ohhh very good catch!

@Trivo25
Copy link
Member Author

Trivo25 commented Jan 18, 2023

!ci-build-me

@mrmr1993 mrmr1993 merged commit 3753a85 into release/2.0.0 Jan 18, 2023
@mrmr1993 mrmr1993 deleted the snarkyjs-assertions branch January 18, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmr1993 mrmr1993 mrmr1993 approved these changes

@MartinMinkov MartinMinkov MartinMinkov approved these changes

@mitschabaude mitschabaude mitschabaude approved these changes

@imeckler imeckler Awaiting requested review from imeckler imeckler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trivo25 @mrmr1993 @MartinMinkov @mitschabaude