Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[develop] Compute the size of the concatenation of all fixed and runtime lookup tables #14004

Merged
merged 3 commits into from
Aug 30, 2023
Merged

[develop] Compute the size of the concatenation of all fixed and runtime lookup tables #14004

merged 3 commits into from
Aug 30, 2023

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Aug 29, 2023 •
edited
Loading

Compute the size of the concatenated fixed and runtime lookup table.
Includes a change in snarky, see o1-labs/snarky#831

Explain your changes:

Explain how you tested your changes:
*

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dannywillems
Implement get_concatenated_fixed_lookup_table_size
8181897 
And use it in step_branch_data to get the right size of the fixed lookup table
@dannywillems dannywillems requested review from a team as code owners August 29, 2023 18:42
@dannywillems dannywillems mentioned this pull request Aug 29, 2023
Closed
@dannywillems dannywillems changed the title Compute the size of the concatenation of all fixed lookup tables [develop] Compute the size of the concatenation of all fixed and runtime lookup tables Aug 29, 2023
@dannywillems
Copy link
Member Author

!ci-build-me

mrmr1993
mrmr1993 requested changes Aug 29, 2023
View reviewed changes
src/lib/pickles/fix_domains.ml Outdated Show resolved Hide resolved
src/lib/pickles/fix_domains.ml Outdated Show resolved Hide resolved
Base automatically changed from feature/custom-gates-develop to develop August 30, 2023 12:36
@mrmr1993
Copy link
Member

!ci-build-me

rbonichon
rbonichon approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@rbonichon rbonichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/crypto/kimchi_backend/common/plonk_constraint_system.ml Show resolved Hide resolved
src/lib/pickles/fix_domains.ml Show resolved Hide resolved
@rbonichon rbonichon mentioned this pull request Aug 30, 2023
Closed
@dannywillems
Copy link
Member Author

!ci-build-me

@dannywillems dannywillems merged commit 71c0dba into develop Aug 30, 2023
1 check passed
@dannywillems dannywillems deleted the fix/13977 branch August 30, 2023 17:10
@dannywillems dannywillems mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbonichon rbonichon rbonichon approved these changes

@mrmr1993 mrmr1993 mrmr1993 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pickles: keep track of the lookup and runtime tables length
3 participants
@dannywillems @mrmr1993 @rbonichon