Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit git branch in node status/error reports #15546

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Omit git branch in node status/error reports #15546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/lib/node_error_service/node_error_service.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ type node_error_report =
; peer_id : string
; ip_address : string
; public_key : Public_key.Compressed.t option
; git_branch : string
; commit_hash : string
; chain_id : string
; contact_info : string option
Expand Down Expand Up @@ -117,7 +116,6 @@ let with_deps ~logger ~f =

let generate_report ~node_state ~contact_info error =
let commit_hash = Mina_version.commit_id in
let git_branch = Mina_version.branch in
let timestamp = Rfc3339_time.get_rfc3339_time () in
let id = Uuid_unix.create () |> Uuid.to_string in
let ({ peer_id
Expand All @@ -138,7 +136,6 @@ let generate_report ~node_state ~contact_info error =
; peer_id
; ip_address
; public_key
; git_branch
; commit_hash
; chain_id
; contact_info
Expand Down
4 changes: 0 additions & 4 deletions src/lib/node_status_service/node_status_service.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ type node_status_data =
; libp2p_output_bandwidth : float
; libp2p_cpu_usage : float
; commit_hash : string
; git_branch : string
; chain_id : string
; peer_id : string
; ip_address : string
Expand All @@ -91,7 +90,6 @@ module Simplified = struct
type t =
{ max_observed_block_height : int
; commit_hash : string
; git_branch : string
; chain_id : string
; peer_id : string
; peer_count : int
Expand Down Expand Up @@ -259,7 +257,6 @@ let start ~logger ~node_status_url ~transition_frontier ~sync_status ~chain_id
; libp2p_output_bandwidth
; libp2p_cpu_usage
; commit_hash = Mina_version.commit_id
; git_branch = Mina_version.branch
; chain_id
; peer_id =
(Node_addrs_and_ports.to_peer_exn addrs_and_ports).peer_id
Expand Down Expand Up @@ -433,7 +430,6 @@ let start_simplified ~logger ~node_status_url ~chain_id ~network
{ Simplified.max_observed_block_height =
!Mina_metrics.Transition_frontier.max_blocklength_observed
; commit_hash = Mina_version.commit_id
; git_branch = Mina_version.branch
; chain_id
; peer_id = (Node_addrs_and_ports.to_peer_exn addrs_and_ports).peer_id
; peer_count = List.length peers
Expand Down