-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendored dependencies #15603
Vendored dependencies #15603
Conversation
… fetch the proper proof-system vendors
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
I have:
while building. Also, i have the following (unrelated) error:
Do you know where it comes from? Commands I use to test:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran #15603 (comment) and it seems to work, not downloading anything. LGTM.
…dencies in Kimchi
Building it one last time to make sure everything is fine using the berkeley branch in proof-systems |
!ci-build-me |
!ci-build-me |
!ci-build-me |
!ci-build-me |
1 similar comment
!ci-build-me |
!approved-for-mainnet |
We were exposed to supply chain attacks because our Rust dependencies were not pinned. This PR fixes that by pinning the kimchi stubs dependencies and also incorporating all vendored dependencies available in proof-systems.
Explain your changes:
kimchi-stubs-vendors
).kimchi-stubs-vendors
repository as a dependency through git submodules.proof-systems:berkeley
.Explain how you tested your changes:
Cargo.toml
.Checklist: