Move Merkle ledger tests to Alcotest #15744
Conversation
|
!ci-build-me |
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
- dune: sort dependencies by alphabetical order - dune: removed dependency on ppx_inline_test
Avoid mixing sprintf and ^ string concatenation operator
rbonichon
force-pushed
the
rb/alcotest_merkle_ledger_tests
branch
from
71e63ac
to
070a164
Compare
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
|
!ci-build-me |
| @@ -59,12 +59,12 @@ module Hash = struct | |||
| * important impossible to create an account such that (merge a b = hash_account account) *) | |||
|
|
|||
| let hash_account account = | |||
| Md5.digest_string ("0" ^ Format.sprintf !"%{sexp: Account.t}" account) | |||
| Md5.digest_string (Format.sprintf !"0%{sexp: Account.t}" account) | |||
There was a problem hiding this comment.
Is this the only non-refactoring code modification of this PR @rbonichon ?
There was a problem hiding this comment.
Kind of. This is also refactoring, isn't it?. But this is why there is a different commit for this change. We could remove it. But I'm not sure it's worth making a separate PR for this specific change.
| accum + Balance.to_nanomina_int (Account.balance acct) | ||
| in | ||
| let parent_sum = | ||
| Maskable.foldi maskable ~init:0 ~f:balance_summer |
There was a problem hiding this comment.
| Maskable.foldi maskable ~init:0 ~f:balance_summer | |
| Maskable.fold maskable ~init:0 ~f:balance_summer |
and remove unused parameter from the balance_summer function (same modification could be applied below)
There was a problem hiding this comment.
unfortunately fold does not exist.
| @@ -156,477 +172,505 @@ module Make (Test : Test_intf) = struct | |||
| in | |||
| test_hashes_at_address addr | |||
|
|
|||
| let%test "parent, mask agree on set" = | |||
There was a problem hiding this comment.
Do I understand correctly that this test was written twice (same code, duplicated)?
|
!ci-build-me |
Use
alcotestto express tests for Merkle ledger(s).Sneaked in a small update in one the test Modules.